X-drilling is quite fashionable and should be used for esthetics only. The drilling distorts the metal and at the same time allows for more opportunities for cracking. Besides, it also reduces swept surface, thus reducing braking ability.

Slots however, release unwanted gases, clean the pad surface and still look reasonably cool. Always my choice.